datadog/chef-handler-datadog#85 - adding the ability to blacklist the… #347
Conversation
|
Thanks @ABrehm264! You also need to pass the attribute to the handler in this hash. |
| # This affects not only event tags but also the host-level tags. | ||
| # This means that all the metrics and service checks coming from the | ||
| # host/Agent would also stop being tagged with these excluded tags. | ||
| # EX: 'APP_.*' allows all tags except those which look like APP_.* |
There was a problem hiding this comment.
nitpick: just for consistency with the lower case of the tags in Datadog it might be better to use a lower-cased pattern in the example. What do you think?
|
@olivielpeau - oh man, I'm sorry I thought I had gotten around to updating my comments to fall more in line with what you had in mind. Please take a gander at it now, it should satisfy the lower case request on the example along with changing the description on what it does. |
|
@ABrehm264 sorry to respond so late, but I realize now that you've missed one of my comments: the cookbook has to pass the attribute to the handler in this hash, otherwise the handler won't be configured with it ;) Once you've changed this the PR looks good to me! |
… tags that the host sends to datadog
ABrehm264
force-pushed
the
datadog/chef-handler-datadog#85
branch
from
bffd489
to
b005f1e
Compare
|
@olivielpeau, check it out now please. I think I got it. crosses fingers |
ABrehm264
force-pushed
the
datadog/chef-handler-datadog#85
branch
from
b005f1e
to
23e5097
Compare
ABrehm264
force-pushed
the
datadog/chef-handler-datadog#85
branch
from
23e5097
to
041f916
Compare
There was a problem hiding this comment.
One more comment to address and it should be good to go, thanks @ABrehm264
| @@ -60,7 +60,8 @@ | |||
| :use_ec2_instance_id => node['datadog']['use_ec2_instance_id'], | |||
| :tag_prefix => node['datadog']['tag_prefix'], | |||
| :url => node['datadog']['url'], | |||
| :extra_endpoints => extra_endpoints | |||
| :extra_endpoints => extra_endpoints, | |||
| :tags_blacklist_regex => ['datadog']['tags_blacklist_regex'] | |||
There was a problem hiding this comment.
['datadog']['tags_blacklist_regex'] should read node['datadog']['tags_blacklist_regex'] instead
|
@olivielpeau - alright, that should now be done |
|
Hello @ABrehm264, I rebased your changes in #397, it'll go out with the next release. Thanks again for the contribution! |
… tags that the host sends to datadog